Referencify tuples #899
Merged
Referencify tuples #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havvy
force-pushed
the
tuple
branch
2 times, most recently
from
c7b1801
to
ff68c99
Compare
I'm not sure "initialized" is the correct word, but I feel like our verbiage around place and value expressions need to be cleaned up anyways. I originally went with "moved", but that's not really correct. I think I want to call it a "value operand", but I need to discuss with others on that first. In any case, it's a lot more correct than what was there before. I renamed `unit_x` to `point` in an example so as to not cause confusion with the unit tuple.
Havvy
added
A-expressions
Co-authored-by: Eric Huss <eric@huss.org>
ehuss
approved these changes
Nov 12, 2020
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2020
Update books ## nomicon 8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63 2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900 - (rust-lang/nomicon#238) - Some tweaks (rust-lang/nomicon#244) - (rust-lang/nomicon#245) - Update atomics.md (rust-lang/nomicon#224) - Update send-and-sync.md (rust-lang/nomicon#187) - fix a typo (rust-lang/nomicon#231) - Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242) - Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1 ## reference 4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d 2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800 - Referencify tuples (rust-lang/reference#899) - Mention Box's partial field moves (rust-lang/reference#837) - Enable triagebot (rust-lang/reference#862) - Update deprecated GitHub Actions commands. (rust-lang/reference#896) ## rust-by-example 1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c 2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500 - Remove incorrect "lambda" terminology ## edition-guide 1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f 2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600 - Clarify slice patterns example (rust-lang/edition-guide#223)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2020
Update books ## nomicon 8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63 2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900 - (rust-lang/nomicon#238) - Some tweaks (rust-lang/nomicon#244) - (rust-lang/nomicon#245) - Update atomics.md (rust-lang/nomicon#224) - Update send-and-sync.md (rust-lang/nomicon#187) - fix a typo (rust-lang/nomicon#231) - Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242) - Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1 ## reference 4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d 2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800 - Referencify tuples (rust-lang/reference#899) - Mention Box's partial field moves (rust-lang/reference#837) - Enable triagebot (rust-lang/reference#862) - Update deprecated GitHub Actions commands. (rust-lang/reference#896) ## rust-by-example 1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c 2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500 - Remove incorrect "lambda" terminology ## edition-guide 1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f 2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600 - Clarify slice patterns example (rust-lang/edition-guide#223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure "initialized" is the correct word, but I feel like our
verbiage around place and value expressions need to be cleaned up
anyways. I originally went with "moved", but that's not really correct.
I think I want to call it a "value operand", but I need to discuss with
others on that first. In any case, it's a lot more correct than what
was there before.
In one example, I renamed
unit_xtopointbecause while it's technically a mathematical unit, it clashes with the unit tuple.I also kept
elementinstead of renaming tofield.