Vagrant Bootstrap Fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant boxes from failing to run rust backend
This script handles pulling in all of the frontend's dependencies. It also creates a symlink from the node_modules directory inside the shared /vagrant folder to the Vagrant VM's home folder. This fixes issues in windows where npm install tries to create symlinks in a NTFS backed file system. It also speeds up the npm install process as Virtual Box's shared folder engine is significantly slower than a native file system, especially with npm's large number of small files.
|
Thanks! Working great for me on a fresh build. I could have sworn I updated that POST_COMMENTS variable, but I must have done it in my virtual machine...oops! |
anoadragon453
pushed a commit
to matrix-org/mscbot
that referenced
this pull request
Jul 6, 2018
Vagrant Bootstrap Fixes Former-commit-id: 1fc6409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small tweaks to improve first time vagrant up experience
Added POST_COMMENTS to vagrant_env.sh
Fixes freshly bootstraped vagrant boxes from failing to run the rust back end. The recent changes require POST_COMMENTS to be true or false before running the rust back end, but this is not included in vagrant_env.sh. I assume false is a sane default in this case.
Created frontend provisioning script
This script handles pulling in all of the frontend's dependencies. It also creates a symlink from the node_modules directory inside the shared /vagrant folder to the Vagrant VM's home folder. This fixes issues in windows where npm install tries to create symlinks in a NTFS backed file system. It also speeds up the npm install process as Virtual Box's shared folder engine is significantly slower than a native file system, especially with npm's large number of small files.
Open Discussion
I'm not sure if having the npm and bower install happen at provision time is the best plan or not. While convenient from my perspective, I can see it being annoying if, for example, someone just wants to hack on the scraper. So I'm not bound to keeping that part in this PR, but the symlink is a definite improvement IMO, it really speeds up the install and helps to work around OS/VM Engine specific quirks.