Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer overflow #560

Merged
merged 18 commits into from
Feb 6, 2015
Merged

Integer overflow #560

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
13489f9
RFC: Scoped attributes for checked arithmetic
glaebhoerl Jun 30, 2014
ee6cc65
typo
glaebhoerl Jun 30, 2014
47ada30
merge wrapping ops into a single `WrappingOps` trait, add `wrapping_rem`
glaebhoerl Jul 3, 2014
797dcad
update to reflect points from discussion
glaebhoerl Aug 26, 2014
c2a842e
minor changes
glaebhoerl Aug 26, 2014
9351afb
Move from active to text
nikomatsakis Jan 7, 2015
3ece24b
Rename to represet new focus
nikomatsakis Jan 7, 2015
d4ed2d1
Edit test to move scoped attributes into future designs and
nikomatsakis Jan 7, 2015
e1af498
Add a paragraph about bit shifts.
nikomatsakis Jan 8, 2015
630dd70
Clarify that overflow panics are not required to be precise,
nikomatsakis Jan 9, 2015
6dbbc70
Substantial rework of the text:
nikomatsakis Jan 29, 2015
9681e60
Add a suggestion for a lint.
nikomatsakis Jan 30, 2015
865eae6
Rephrase the *optional* mode so it is deterministic; but make it clear
nikomatsakis Jan 30, 2015
af776c6
Add methods for wrapping versions of the `as xx` conversions.
nikomatsakis Jan 30, 2015
22ecff8
Refine the text on delayed panics somewhat.
nikomatsakis Jan 30, 2015
341ff45
Small suggestions from @mkaufmann.
nikomatsakis Jan 30, 2015
648e1b1
Rewrite the unresolved questions to clearly highlight that the semantics
nikomatsakis Jan 30, 2015
9fb9ad6
Add methods for lshift and rshift to the wrapping trait.
nikomatsakis Jan 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add methods for lshift and rshift to the wrapping trait.
  • Loading branch information
@nikomatsakis
nikomatsakis committed Jan 30, 2015
commit 9fb9ad698cf83e77b45cfbe9845962f5a8ca6d35
5 changes: 4 additions & 1 deletion text/0000-integer-overflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ pub trait WrappingOps {
fn wrapping_mul(self, rhs: Self) -> Self;
fn wrapping_div(self, rhs: Self) -> Self;
fn wrapping_rem(self, rhs: Self) -> Self;


fn wrapping_lshift(self, amount: u32) -> Self;
fn wrapping_rshift(self, amount: u32) -> Self;

fn wrapping_as_u8(self, rhs: Self) -> u8;
fn wrapping_as_u16(self, rhs: Self) -> u16;
fn wrapping_as_u32(self, rhs: Self) -> u32
Expand Down