Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Add how RLS can be built without clippy_lints #1267

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add how RLS can be built without clippy_lints #1267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,18 @@ you'll need a recent nightly compiler to build it.
git clone https://github.com/rust-lang/rls.git
cd rls
cargo build --release
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's deleted by mistake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's 6 backticks instead of none 😅
No worries, I'll fix that myself - thanks for writing that up!

``````

#### If RLS couldn't be built with clippy

Sometimes nightly toolchain changes break the `clippy_lints` dependency.
Since RLS depends on `clippy_lints` by default, those changes can also break RLS itself.
In this case, you can build RLS like this:

`cargo build --no-default-features` (disabling the clippy feature)

And sometimes git revision of `clippy` submodule in the Rust repo (https://github.com/rust-lang/rust/tree/master/src/tools) and `clippy_lints` dependency of RLS is different.
In this case, submit a PR here updating the `clippy_lints` dependency to the git revision pulled from the Rust tree.

### Step 3: Connect the RLS to your compiler

Expand Down