Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

fix(cmd): make clear_env_rust_log default to false #1486

Merged
merged 1 commit into from
Jun 21, 2019
Merged

fix(cmd): make clear_env_rust_log default to false #1486

merged 1 commit into from
Jun 21, 2019

Conversation

schomatis
Copy link
Contributor

Since the CLI is intended for debugging purposes.

Xanewok
Xanewok suggested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks! Mind running rustfmt and adding a comment on why we're setting it to false here?

@schomatis
Copy link
Contributor Author

@Xanewok Fixed.

@schomatis schomatis mentioned this pull request Jun 21, 2019
Closed
@Xanewok Xanewok merged commit 36def18 into rust-lang:master Jun 21, 2019
@Xanewok
Copy link
Member

Xanewok commented Jun 21, 2019

Thanks!

@schomatis schomatis deleted the fix/cmd/make-clear_env_rust_log-false branch June 21, 2019 15:59
@Xanewok Xanewok mentioned this pull request Jun 27, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge of rust-lang#62176 - Xanewok:update-rls, r=alexcrichton
c53cc2b 
Update RLS

Merged PRs:
* fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486)
  - Retain `RUST_LOG` in `rls --cli` mode
* Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497)
  - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config)
* Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500)
  - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇‍♂️ )
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge of rust-lang#62176 - Xanewok:update-rls, r=alexcrichton
24a356f 
Update RLS

Merged PRs:
* fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486)
  - Retain `RUST_LOG` in `rls --cli` mode
* Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497)
  - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config)
* Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500)
  - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇‍♂️ )
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge of rust-lang#62176 - Xanewok:update-rls, r=alexcrichton
65f1ff4 
Update RLS

Merged PRs:
* fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486)
  - Retain `RUST_LOG` in `rls --cli` mode
* Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497)
  - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config)
* Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500)
  - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇‍♂️ )
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xanewok Xanewok Xanewok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schomatis @Xanewok