-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore build commit and build date from build artifacts for proc macros #9916
Comments
What does The |
the patch I sent makes it work, so that seems to be the only place that happens |
There's another place -- #8624, but I'm not sure how that works, since my toolchain doesn't seem to embed the commit hash in the symbol paths. On the other hand, #9872 implies they are still needed. Anyway, it seems reasonable to merge your changes. I'll do that a bit later, unless you come up with a PR first. |
I'm running rustc 1.54.0 provided by my distribution (openSUSE Tumbleweed). However, different to the rustc compiled for rustup, running
rustc --version
just returnswithout any additional
(commit builtdate)
suffix. Howeverhttps://github.com/rust-analyzer/rust-analyzer/blob/b641a66078ce2f2363e9a3b050ba448b93fb7cb6/crates/proc_macro_api/src/version.rs#L41
tries to parse it and thus throws an error on projects using proc macros:
I've attached a fairly simple patch for rust-analyzer that fixes it (at least in my case), by making commit and date optional. Feel free to merge it, if you consider it quality enough.
0001-proc_macro_api-make-commit-date-suffix-of-binary-ver.patch.gz
The text was updated successfully, but these errors were encountered: