Add back colons around inlay hints

[lnicola]

Fixes #2797 (comment).

I originally thought that other extensions don't include the colons, but the TypeScript one seems to do.

[lnicola]

[lnicola]

CC @rami3l

[lnicola]

I'm not sure whether it's fine to have this padding / formatting logic here. It feels wrong, but on the other hand it's nice to be easily able to check how these are set.

[Veykril]

Definitely in favor of getting these back, otherwise closures in arguments are very confusing with their labels 😬

[lnicola]

bors r=Veykril

[HKalbasi]

What is the reason of disabling paddings for TypeHints? Typescript has both left padding and :

[lnicola]

I tried to match the aspect of hard-written code, i.e. let tactic: String. And on the right side, it looked pretty ugly:

(notice how it appears to have two spaces)

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)

[jhgg]

I wonder if we can discuss this matter with vscode proper. The new inlay hints are functionally better, but look pretty awful. If they removed this padding it would make both rust analyzer and TS language server look and feel much better.

[lnicola]

@jhgg which padding? Some of it is actually controllable by the extension.

[nilehmann]

oh no, I preferred the inlay hints without the colons :(

[jhgg]

@jhgg which padding? Some of it is actually controllable by the extension.

See the awkward padding between the x and :?

So this is really only visible this way because I tried to make them look more faded compared to stock inlay hints:

I think it would be a good editor feature to simply hide the outer padding, basically, chop off:

---

It even overlaps the highlight >_>

[jhgg]

BTW, opened a vscode issue regarding the padding here: microsoft/vscode#145191