Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update metavariable expression implementation #16165

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 19, 2023

Fixes #16154
This duplicates behavior of that before and after PR rust-lang/rust#117050 based on the toolchain version. There are some 1.76 nightlies that are still broken (any before that PR basically) but fetching and storing the commit makes little sense to me (opposed to the toolchain version).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2023
@Veykril Veykril force-pushed the meta-vars branch 6 times, most recently from b3502f8 to d43be0d Compare December 19, 2023 13:11
@Veykril
Copy link
Member Author

Veykril commented Dec 20, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 20, 2023

📌 Commit f48ecb6 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 20, 2023

⌛ Testing commit f48ecb6 with merge 7bdf48c...

@bors
Copy link
Collaborator

bors commented Dec 20, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7bdf48c to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing impls for tuples?
3 participants