Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow rust files to be used linkedProjects #17118

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 21, 2024

With this, script files become more usable as the user can at least add them manually to the linked projects, allowing them to be used "on the (manual) fly" without having to open a separate vscode window that only has files open and no folder.

Also makes build scripts work for them (including proc-macros)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2024
@Veykril
Copy link
Member Author

Veykril commented Apr 21, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

📌 Commit af3fc73 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

⌛ Testing commit af3fc73 with merge 1948d46...

bors added a commit that referenced this pull request Apr 21, 2024
feat: Allow rust files to be used linkedProjects

With this, script files become more usable as the user can at least add them manually to the linked projects, allowing them to be used "on the (manual) fly" without having to open a separate vscode window that only has files open and no folder.

Also makes build scripts work for them (though no proc-macros, for some reason the dylib field is not populated in the output)
@bors
Copy link
Collaborator

bors commented Apr 21, 2024

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Apr 21, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

📌 Commit a2ed683 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

⌛ Testing commit a2ed683 with merge f512a5e...

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f512a5e to master...

@bors bors merged commit f512a5e into rust-lang:master Apr 21, 2024
11 checks passed
@Veykril Veykril deleted the linked-rust-files branch April 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants