Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the latest Semantic Tokens Proposal for LSP 3.16 #5930

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Sep 1, 2020

This stabilizes call hierarchy and semantic tokens features on the client side and changes the server-side semantic tokens protocol to match the latest proposal for 3.16.

The server-side change will break clients depending on the earlier semantic tokens draft.

Fixes #4942

@kjeremy
Copy link
Contributor Author

kjeremy commented Sep 1, 2020

This brings in a few more token types like "enumMember" and the "async" modifier

@kjeremy kjeremy marked this pull request as ready for review September 2, 2020 13:42
@kjeremy kjeremy changed the title Move to vscode-languageclient 7.0.0-next.9 Migrate to the latest Semantic Tokens Proposal for LSP 3.16 Sep 2, 2020
@matklad
Copy link
Member

matklad commented Sep 2, 2020

bors r+

Thanks!

@bors
Copy link
Contributor

bors bot commented Sep 2, 2020

@bors bors bot merged commit 7f79dbc into rust-lang:master Sep 2, 2020
@kjeremy kjeremy deleted the latest-semantic-tokens branch September 2, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep up with evolving SemanticTokens rework
2 participants