Rename CrateDefMap to DefMap
#7336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose handling local items by computing a
DefMapfor every block expression, using the regular (early) name resolution algorithm. The result of that will be aDefMapthat has a reference to the parentDefMap, which is either the one computed for the containing block expression, or the crate's rootDefMap. Name resolution will fall back to a name in the parentDefMapif it cannot be resolved in the inner block.The
DefMaps computed for block expressions will go through a separate query that can be garbage-collected much more aggressively, since theseDefMaps should be cheap to compute and are never part of a crate's public API.The first step towards that is to make
CrateDefMapnot specific to crates anymore, hence this rename (if this plans sounds reasonable).cc #7325 and #1165