Correct wasm32 ABI #1952
Closed
Correct wasm32 ABI #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
devsnek
commented
Dec 21, 2020
| TypeKind::Alias(id) => { | ||
| ctx.resolve_type(id).needs_wasm32_abi_hack(ctx) | ||
| } | ||
| TypeKind::Comp(_) => true, |
There was a problem hiding this comment.
not sure what to do here. compinfo::layout() is none, compinfo.fields() -> field::layout() is none, etc. How do I figure out the size and shape of this comp?
There was a problem hiding this comment.
You want self.layout(ctx), compinfo::layout() is just a fallback if we can't get the right size from llvm.
|
We landed a fix for wasm32-wasi in rustc, so this is now only needed for wasm32-unknown-unknown. Since I'm personally targeting wasi, it is unlikely that I will finish this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1944