tests: Guess modern libclang version when we fail to parse a version. #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adetaylor @hlopko, can you confirm that with this patch, |
|
I've uploaded #1996 that fixes the problem for me on my linux and mac machines. I personally would prefer if bindgen panicked when it cannot parse the clang version, but I can imagine some workflows would benefit from setting the default as implemented in this PR. |
|
Yeah, this is only used for testing and for an old-clang-workaround (where we already treat "unknown" as "modern"), so this is consistent with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the test failures described in #1991 and #1975 on modern Mac.