Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for unions #922

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Update doc for unions #922

merged 1 commit into from
Aug 20, 2017

Conversation

tmfink
Copy link
Contributor

@tmfink tmfink commented Aug 19, 2017

Addresses #832

I also modified the --help text to print the default Rust target.

src/options.rs Outdated
"Version of the Rust compiler to target. Valid options are: {:?}. Defaults to {:?}.",
RUST_TARGET_STRINGS,
String::from(RustTarget::default()),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Indentation of the paren should go to the left.

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@emilio
Copy link
Contributor

emilio commented Aug 20, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 22508ce has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 22508ce with merge 79447a2...

bors-servo pushed a commit that referenced this pull request Aug 20, 2017
Update doc for unions

Addresses #832

I also modified the `--help` text to print the default Rust target.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing 79447a2 to master...

@bors-servo bors-servo merged commit 22508ce into rust-lang:master Aug 20, 2017
@fitzgen
Copy link
Member

fitzgen commented Aug 21, 2017

Thanks for the docs update!

@tmfink
Copy link
Contributor Author

tmfink commented Aug 22, 2017

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants