Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Gate rustc on both Azure and (GitHub Actions - macOS) #848

Closed
tmiasko opened this issue Jun 13, 2020 · 2 comments · Fixed by #879
Closed

Gate rustc on both Azure and (GitHub Actions - macOS) #848

tmiasko opened this issue Jun 13, 2020 · 2 comments · Fixed by #879

Comments

@tmiasko
Copy link

tmiasko commented Jun 13, 2020

Gate rustc CI on both Azure and GitHub Actions with the exception of macOS
builders to quickly detect builds that will inevitably fail on Azure, while
avoiding spurious failures described in rust-lang/rust#71988.

Time to failure (TTF) on Azure and GitHub Actions (GHA) from a few different
rollups (measurements for GHA include non-spurious failures from macOS builders
under simplifying assumption that they would also fail elsewhere around the
same time):

Rollup Azure TTF GHA TTF
73271 1h 48m 1s 22m 4s
73240 1h 7m 30s 23m 52s
73231 2h 22m 45s 25m 48s
73168 1h 50m 34s 23m 41s
73064 2h 19m 42s 42m 13s
73062 1h 58m 42s 41m 24s
73053 2h 5m 57s 37m 32s

Potential drawbacks: increased likelihood of spurious failures.
@pietroalbini
Copy link
Member

That's a great point! Added this to this week's infrastructure team meeting.

@pietroalbini pietroalbini mentioned this issue Jun 17, 2020
Merged
@tmiasko
Copy link
Author

tmiasko commented Jun 20, 2020

Blocked on recently introduced failures on arm-android & GitHub Actions rust-lang/rust#73535.

Manishearth added a commit to Manishearth/rust that referenced this issue Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
c2ba2e4 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 20, 2020
@RalfJung
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
5ea7ef4 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
89434b6 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
929f032 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
@pietroalbini pietroalbini mentioned this issue Jun 29, 2020
Merged
@pietroalbini pietroalbini linked a pull request Jun 29, 2020 that will close this issue
Double-gate rustc on GHA and Azure #879
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Double-gate rustc on GHA and Azure rust-lang/rust-central-station
2 participants
@pietroalbini @tmiasko