Implement a lint to replace manual bit rotations with rotate_left/rot… #12983
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
frp
force-pushed
the
manual_rotate
branch
5 times, most recently
from
c99d991
to
657d60e
Compare
|
Thank you! @bors r+ |
Implement a lint to replace manual bit rotations with rotate_left/rot… Fixes #6861 r? `@llogiq` --- changelog: add [`manual_rotate`] lint
|
💔 Test failed - checks-action_test |
|
I cannot see how that error would be related. Might be transient. @bors retry |
Implement a lint to replace manual bit rotations with rotate_left/rot… Fixes #6861 r? `@llogiq` --- changelog: add [`manual_rotate`] lint
|
💔 Test failed - checks-action_test |
use short message format in integration test While checking #12983, bors came upon a cargo change that put "E0463" into the standard error (as part of a test case code snippet), which the integration test picked up to fail the build. Talk about unforeseen consequences. So this PR just changes the integration test to use short message format in order to not include the code snippets in the output. Hopefully that will fix the problem. r? `@Alexendoo` --- changelog: none
|
I can reproduce the same failure locally by checking out The last change on I think this commit in cargo might be the cause: rust-lang/cargo@28d213b - it adds the exact lines the integration test is unhappy about. How do we proceed? |
|
I have pushed a fix, which was just merged to master. If you pull & rebase onto that, it should work. |
|
Thank you! @bors r+ |
Implement a lint to replace manual bit rotations with rotate_left/rot… Fixes #6861 r? `@llogiq` --- changelog: add [`manual_rotate`] lint
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 1 review requesting changes by reviewers with write access. |
|
Thank you! @bors r+ |
Implement a lint to replace manual bit rotations with rotate_left/rot… Fixes #6861 r? `@llogiq` --- changelog: add [`manual_rotate`] lint
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 1 review requesting changes by reviewers with write access. |
|
That is new. @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Fixes #6861
r? @llogiq
changelog: add [
manual_rotate] lint