Update clippy for latest rustc changes #4650
Conversation
|
This is for rust-lang/rust#65193. cc @Manishearth |
|
This will need another pass since we need to |
phansch
added
the
S-waiting-on-review
|
Got a try build we can rustup-toolchain-install-master to test with? |
|
A lot of lib.rs is autogenerated with update-lints, so we can update that to do whatever registry you need |
Mark-Simulacrum
force-pushed
the
clippy-up-lintstore-lockless
branch
from
004a3a8
to
50a082d
Compare
|
Attempted to update update-lints to do the right thing and pushed relevant changes. Working on a try build in the rust PR. |
|
☔ The latest upstream changes (presumably #4560) made this pull request unmergeable. Please resolve the merge conflicts. |
|
rust-lang/rust#65193 was merged so we need this now |
Specifically, this revises the clippy integration to utilize a new callback to register its lints, as the prior editing of lint store in Session is no longer possible.
flip1995
force-pushed
the
clippy-up-lintstore-lockless
branch
from
50a082d
to
ef02e3a
Compare
|
You need to revert 974a05b to rustup rustc-dev component. |
|
Oh so bors decided to finally merge this PR 😄 On it 👍 |
This reverts commit 974a05b.
|
@bors treeclosed=10 p=10 |
flip1995
force-pushed
the
clippy-up-lintstore-lockless
branch
from
5713240
to
b261664
Compare
|
Now we should be good (at least |
|
(Let me know if you need anything from me here) |
|
CI passed. |
|
@bors r+ |
|
📌 Commit b261664 has been approved by |
…=phansch Update clippy for latest rustc changes Specifically, this revises the clippy integration to utilize a new callback to register its lints, as the prior editing of lint store in Session is no longer possible. --- changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
|
@bors treeclose- |
Specifically, this revises the clippy integration to utilize a new
callback to register its lints, as the prior editing of lint store in
Session is no longer possible.
changelog: none