Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint for assertions in functions returning Result #6280

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Add lint for assertions in functions returning Result #6280

merged 3 commits into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. panic_in_result_fn: Extend to also check usages of [debug_]assert* ma… 

    …cros

Also, the macro-finding logic has been moved to the util module, for
use by future lints.
    @dp304 @ebroto
    dp304 authored and ebroto committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    e58c7dd View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Use array slice instead of `Vec` in `find_macro_calls` as suggested by @ebroto

Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
    @dp304 @ebroto
    dp304 and ebroto committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    bdad790 View commit details
    Browse the repository at this point in the history

  3. Update reference file

    @ebroto
    ebroto committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    16d0e56 View commit details
    Browse the repository at this point in the history