Organize functions into functions module #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Mar 29, 2021
Comment on lines
+60
to
+62
| "this returns a `Result<_, ()>", | ||
| None, | ||
| "use a custom Error type instead", |
There was a problem hiding this comment.
nits, it might be better to fix this in another PR because the stderr file needs to be fixed.
Suggested change
| "this returns a `Result<_, ()>", | |
| None, | |
| "use a custom Error type instead", | |
| "this returns a `Result<_, ()>`", | |
| None, | |
| "use a custom `Error` type instead", |
There was a problem hiding this comment.
Ok, I'll address this in another PR.
giraffate
added
S-waiting-on-author
|
Changes: |
giraffate
approved these changes
Mar 30, 2021
|
@bors r+ It looks good, thanks! |
|
📌 Commit 541c8b8 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Mar 31, 2021
result_unit_err: Fix typo changelog: result_unit_err: fix typo in a diagnostic message r? `@giraffate` fixes #6990 (comment).
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6680
Rearrange lints in
functions.changelog: none