Skip to content

Commit

Permalink
Rollup merge of #57584 - nnethercote:rm-connect_timeout_unroutable, r…
Browse files Browse the repository at this point in the history
…=sfackler

Remove the `connect_timeout_unroutable` test.

It requires an unreachable IP address, but there is no such thing, and
this has caused it to fail for multiple people.

Fixes #44698, fixes #50065.

r? @sfackler
  • Loading branch information
Centril authored Jan 14, 2019
2 parents 4112aef + 24a9ac7 commit 47ccf2a
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/libstd/net/tcp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1673,17 +1673,6 @@ mod tests {
})
}

#[test]
fn connect_timeout_unroutable() {
// this IP is unroutable, so connections should always time out,
// provided the network is reachable to begin with.
let addr = "10.255.255.1:80".parse().unwrap();
let e = TcpStream::connect_timeout(&addr, Duration::from_millis(250)).unwrap_err();
assert!(e.kind() == io::ErrorKind::TimedOut ||
e.kind() == io::ErrorKind::Other,
"bad error: {} {:?}", e, e.kind());
}

#[test]
fn connect_timeout_unbound() {
// bind and drop a socket to track down a "probably unassigned" port
Expand Down

0 comments on commit 47ccf2a

Please sign in to comment.