Skip to content

Commit

Permalink
handle stage0 cargo and rustc separately
Browse files Browse the repository at this point in the history
This change allows setting either `build.cargo` or `build.rustc` without requiring
both to be set simultaneously, which was not possible previously.

To try it, set `build.rustc` without setting `build.cargo`, and try to bootstrap on clean build.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
  • Loading branch information
onur-ozkan committed Aug 23, 2024
1 parent a32d4a0 commit 569e0e1
Showing 1 changed file with 15 additions and 8 deletions.
23 changes: 15 additions & 8 deletions src/bootstrap/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,9 +533,11 @@ def download_toolchain(self):
bin_root = self.bin_root()

key = self.stage0_compiler.date
if self.rustc().startswith(bin_root) and \
(not os.path.exists(self.rustc()) or
self.program_out_of_date(self.rustc_stamp(), key)):
need_rustc = self.rustc().startswith(bin_root) and \
(not os.path.exists(self.rustc()) or self.program_out_of_date(self.rustc_stamp(), key))
need_cargo = self.cargo().startswith(bin_root) and not os.path.exists(self.cargo())

if need_rustc or need_cargo:
if os.path.exists(bin_root):
# HACK: On Windows, we can't delete rust-analyzer-proc-macro-server while it's
# running. Kill it.
Expand Down Expand Up @@ -568,11 +570,16 @@ def download_toolchain(self):

toolchain_suffix = "{}-{}{}".format(rustc_channel, self.build, tarball_suffix)

tarballs_to_download = [
("rust-std-{}".format(toolchain_suffix), "rust-std-{}".format(self.build)),
("rustc-{}".format(toolchain_suffix), "rustc"),
("cargo-{}".format(toolchain_suffix), "cargo"),
]
tarballs_to_download = []

if need_rustc:
tarballs_to_download.append(
("rust-std-{}".format(toolchain_suffix), "rust-std-{}".format(self.build))
)
tarballs_to_download.append(("rustc-{}".format(toolchain_suffix), "rustc"))

if need_cargo:
tarballs_to_download.append(("cargo-{}".format(toolchain_suffix), "cargo"))

tarballs_download_info = [
DownloadInfo(
Expand Down

0 comments on commit 569e0e1

Please sign in to comment.