Skip to content

Commit

Permalink
Add test for Apple's -weak_framework linker argument
Browse files Browse the repository at this point in the history
  • Loading branch information
madsmtm committed Mar 18, 2024
1 parent a47d390 commit ec5c8fe
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 21 deletions.
21 changes: 0 additions & 21 deletions tests/run-pass-valgrind/osx-frameworks.rs

This file was deleted.

8 changes: 8 additions & 0 deletions tests/ui/linkage-attr/framework.omit.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: linking with `cc` failed: exit status: 1
|
ld: Undefined symbols:
_CFRunLoopGetTypeID, referenced from:
clang: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to 1 previous error

This comment has been minimized.

Copy link
@zmodem

zmodem Apr 3, 2024

Contributor

We're seeing test failures where "The actual stderr differed from the expected stderr." See https://issues.chromium.org/u/1/issues/332562251#comment1

This comment has been minimized.

Copy link
@madsmtm

madsmtm Apr 3, 2024

Author Contributor

I've opened #123410 for that.

30 changes: 30 additions & 0 deletions tests/ui/linkage-attr/framework.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Check that linking frameworks on Apple platforms works.
//@ only-macos
//@ revisions: omit link weak both
//@ [omit]build-fail
//@ [link]run-pass
//@ [weak]run-pass
//@ [both]run-pass

// The linker's exact error output changes between Xcode versions.
//@ compare-output-lines-by-subset
//@ normalize-stderr-test: "Undefined symbols for architecture .*" -> "ld: Undefined symbols:"
//@ normalize-stderr-test: "._CFRunLoopGetTypeID.," -> "_CFRunLoopGetTypeID,"

#![cfg_attr(any(weak, both), feature(link_arg_attribute))]

#[cfg_attr(any(link, both), link(name = "CoreFoundation", kind = "framework"))]
#[cfg_attr(
any(weak, both),
link(name = "-weak_framework", kind = "link-arg", modifiers = "+verbatim"),
link(name = "CoreFoundation", kind = "link-arg", modifiers = "+verbatim")
)]
extern "C" {
fn CFRunLoopGetTypeID() -> core::ffi::c_ulong;
}

pub fn main() {
unsafe {
CFRunLoopGetTypeID();
}
}

0 comments on commit ec5c8fe

Please sign in to comment.