Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running x build --help panics #106313

Closed
albertlarsan68 opened this issue Dec 30, 2022 · 0 comments · Fixed by #106314
Closed

Running x build --help panics #106313

albertlarsan68 opened this issue Dec 30, 2022 · 0 comments · Fixed by #106314
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@albertlarsan68
Copy link
Member

albertlarsan68 commented Dec 30, 2022 •
edited
Loading

I tried this command on this repo:

x build --help

I expected to see this happen: the help is displayed

Instead, this happened: a panic occured thread 'main' panicked at 'metadata missing for test: {}', lib.rs:1402:36

Meta

HEAD: b38a6d3

@rustbot labels +A-bootstrap
Cc @jyn514
@albertlarsan68 albertlarsan68 added the C-bug Category: This is a bug. label Dec 30, 2022
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 30, 2022
@albertlarsan68 albertlarsan68 mentioned this issue Dec 30, 2022
Closed
@jyn514 jyn514 mentioned this issue Dec 31, 2022
Merged
jyn514 added a commit to jyn514/rust that referenced this issue Dec 31, 2022
@jyn514
Rollup merge of rust-lang#106314 - jyn514:fix-panic, r=jyn514
71909ef 
Fix panic on `x build --help`

Fixes rust-lang#106313. This avoids trying to run `get_help` unless we actually need to see the paths that are available for the subcommand.

This originally regressed in rust-lang#106166.
jyn514 added a commit to jyn514/rust that referenced this issue Dec 31, 2022
@jyn514
Rollup merge of rust-lang#106314 - jyn514:fix-panic, r=jyn514
b58e611 
Fix panic on `x build --help`

Fixes rust-lang#106313. This avoids trying to run `get_help` unless we actually need to see the paths that are available for the subcommand.

This originally regressed in rust-lang#106166.
@bors bors closed this as completed in 7f930b4 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic on x build --help jyn514/rust
2 participants
@rustbot @albertlarsan68