Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove imports of the form "use path1, path2;" #10911

Closed
alexcrichton opened this issue Dec 10, 2013 · 0 comments
Closed

Remove imports of the form "use path1, path2;" #10911

alexcrichton opened this issue Dec 10, 2013 · 0 comments

Comments

@alexcrichton
Copy link
Member

This is a relic from an age long since past, and this import form should be removed.
This code should fail to parse:

use foo, bar, baz;
use foo::bar,
    bar::baz,
    foo::bar::{baz, lol};
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10911 - lochetti:fix_9657, r=Alexendoo
b095247 
Don't linting `as_conversions` in proc macros

Don't linting `as_conversions` if code was generated by procedural macro.

This PR fixes rust-lang/rust-clippy#9657

I implemented the fix changing the lint code to be a `LateLintPass` in order to be able to use the `is_from_proc_macro` out of the box. If the reviwer thinks that it would be better to do the other way (implementing `WithSearchPat`) just let me know. I might need some help in implementing it for the `ustc_ast::ast::Expr`

changelog: [`as_conversions`] avoiding warnings in macro-generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton