Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loongarch64-unknown-linux-musl target does not build #122266

Closed
saethlin opened this issue Mar 10, 2024 · 1 comment · Fixed by #122269
Closed

loongarch64-unknown-linux-musl target does not build #122266

saethlin opened this issue Mar 10, 2024 · 1 comment · Fixed by #122269
Labels
O-loongarch Target: LoongArch (LA32R, LA32S, LA64) O-musl Target: The musl libc

Comments

@saethlin
Copy link
Member

cargo +nightly build -Zbuild-std --target=loongarch64-unknown-linux-musl
rustc 1.78.0-nightly (2d24fe591 2024-03-09)
binary: rustc
commit-hash: 2d24fe591f30386d6d5fc2bb941c78d7266bf10f
commit-date: 2024-03-09
host: x86_64-unknown-linux-gnu
release: 1.78.0-nightly
LLVM version: 18.1.0

The output is miles of errors like this:

error[E0412]: cannot find type `c_char` in the crate root
  --> /home/ben/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.153/src/unix/mod.rs:52:29
   |
6  | pub type c_schar = i8;
   | ---------------------- similarly named type alias `c_schar` defined here
...
52 |         pub gr_name: *mut ::c_char,
   |                             ^^^^^^
   |
help: a type alias with a similar name exists
   |
52 |         pub gr_name: *mut ::c_schar,
   |                             ~~~~~~~
help: consider importing this type alias
   |
155+         use ffi::c_char;
   |
help: if you import `c_char`, refer to it directly
   |
52 -         pub gr_name: *mut ::c_char,
52 +         pub gr_name: *mut c_char,
   |

I think this target has somehow slipped past our CI? Maybe I'm searching our codebase wrong, but I don't think I can find any tests for it? Note that this affects the -musl target specifically, as identified by the Miri cron job that tries to build all tier 2 targets: https://github.com/rust-lang/miri/blob/66cf3418bd5f9de9a726681c054b3852096d6a68/.github/workflows/sysroots.yml which just failed: https://github.com/rust-lang/miri/actions/runs/8219608617/job/22477773992

cc target maintainers: @heiher @xiangzhai @zhaixiaojuan @xen0n

@saethlin saethlin added the C-bug Category: This is a bug. label Mar 10, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 10, 2024
@saethlin saethlin added O-musl Target: The musl libc O-loongarch Target: LoongArch (LA32R, LA32S, LA64) labels Mar 10, 2024
@heiher
Copy link
Contributor

heiher commented Mar 10, 2024

I'm sorry. The loongarch64-unknown-linux-musl is incorrectly written in the Tier 2 table in platform-support.md.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 10, 2024
doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3

Fixes rust-lang#122266
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 10, 2024
doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3

Fixes rust-lang#122266
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 10, 2024
doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3

Fixes rust-lang#122266
@bors bors closed this as completed in 1bad698 Mar 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 10, 2024
Rollup merge of rust-lang#122269 - heiher:fix-doc, r=workingjubilee

doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3

Fixes rust-lang#122266
@saethlin saethlin removed C-bug Category: This is a bug. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 10, 2024
heiher added a commit to heiher/rust that referenced this issue Aug 29, 2024
heiher added a commit to heiher/rust that referenced this issue Sep 23, 2024
heiher added a commit to heiher/rust that referenced this issue Sep 23, 2024
heiher added a commit to heiher/rust that referenced this issue Sep 23, 2024
heiher added a commit to heiher/rust that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-loongarch Target: LoongArch (LA32R, LA32S, LA64) O-musl Target: The musl libc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants