Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crate-method-reexport-grrrrrrr.rs broken by recent (metadata?) changes #3233

Closed
msullivan opened this issue Aug 20, 2012 · 2 comments
Closed

crate-method-reexport-grrrrrrr.rs broken by recent (metadata?) changes #3233

msullivan opened this issue Aug 20, 2012 · 2 comments
Assignees
@pcwalton
Labels
A-linkage Area: linking into static, shared libraries and binaries
Milestone
0.6

Comments

@msullivan
Copy link
Contributor

The run-pass test crate-method-reexport-grrrrrrr.rs doesn't work any more. I'm pretty sure the culprit is @pcwalton's recent changes to metadata.

I xfail'd the test because the tree had been burning for a long time, but it should really be looked into.
@ghost ghost assigned pcwalton Aug 20, 2012
@msullivan
Copy link
Contributor Author

This may be in some way related to #3155, which is referenced in a FIXME in the test.

@catamorphism
Copy link
Contributor

Works now.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Jan 28, 2024
@bors
Auto merge of rust-lang#3233 - RalfJung:trophy, r=RalfJung
9f4d1a4 
Add portable-atomic-util bug to "bugs found" list

At least, reading https://notgull.net/cautionary-unsafe-tale/ it seems fair to say Miri found this bug. `@notgull` please let me know if you are okay with having this listed here.
jaisnan added a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@celinval @jaisnan
Remove empty box creation from contracts impl (rust-lang#3233)
e9eeef7 
There seems to be an issue in CBMC contracts implementation that it
assumes that `free` must have a body. However, slicing can remove `free`
body if the harness does not allocate anything.

diffblue/cbmc#8317

We used to create an empty Box before to force `free` to be in scope.
Instead, just invoke `free(NULL)` which is a no-op.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

Co-authored-by: Jaisurya Nanduri <91620234+jaisnan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwalton pcwalton

Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@pcwalton @msullivan @catamorphism