Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/bootstrap/cc.rs: Support specifying AR in config or via environment variable #41821

Closed
devurandom opened this issue May 7, 2017 · 2 comments
Closed

src/bootstrap/cc.rs: Support specifying AR in config or via environment variable #41821

devurandom opened this issue May 7, 2017 · 2 comments
Assignees
@petrochenkov
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@devurandom
Copy link
Contributor

src/bootstrap/cc.rs currently derives AR from CC via build_helper.cc2ar(). However, it would be very helpful if AR could be specified in config.toml, like CC can. Alternatively, it would be desirable to be able to provide the binary name via a environment variable.
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 9, 2017
@alexcrichton
Copy link
Member

Makes sense to me! Should be relatively easy to implement, and if anyone's interested in doing so I don't mind helping out!

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the impl period milestone Sep 15, 2017
@aturon aturon removed this from the impl period milestone Sep 15, 2017
@petrochenkov
Copy link
Contributor

I have a branch on which archiver and linker can be supplied to rustbuild explicitly, will send a PR soon.

@petrochenkov petrochenkov self-assigned this Oct 9, 2017
@petrochenkov petrochenkov mentioned this issue Oct 10, 2017
Merged
bors added a commit that referenced this issue Oct 16, 2017
@bors
Auto merge of #45191 - petrochenkov:yesar, r=Mark-Simulacrum
9223c39 
rustbuild: Support specifying archiver and linker explicitly

With this patch `x.py test` passes without toolchain being in `PATH` if `cc`, `cxx`, `ar`, `linker` and `gdb` are specified in `config.toml` (except for a few `run-make` tests using `nm`).

Fixes #41821
r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrochenkov petrochenkov

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@devurandom @alexcrichton @aturon @Mark-Simulacrum @petrochenkov