Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: section anchor symbol can be difficult to click #49485

Closed
ehuss opened this issue Mar 29, 2018 · 4 comments
Closed

rustdoc: section anchor symbol can be difficult to click #49485

ehuss opened this issue Mar 29, 2018 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Mar 29, 2018

Some of the section anchors that appear when you hover over an item can be difficult to click. It seems to disappear when the mouse transitions over the spacing between the item and the symbol.

demo

Tested on a variety of browsers, all seem to behave similarly.

Rust 1.25 seems OK (there isn't as much spacing). I only notice this on nightly (1.26.0-nightly (e5277c1 2018-03-28)).
@GuillaumeGomez
Copy link
Member

There is already a PR to fix it here.

@pietroalbini pietroalbini added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools-rustdoc labels Apr 6, 2018
@kzys
Copy link
Contributor

kzys commented Aug 25, 2018

Resolving? #49510 has been merged.

@GuillaumeGomez
Copy link
Member

Oh indeed!

@ehuss
Copy link
Contributor Author

ehuss commented Aug 25, 2018

Actually it still happens with section headers. I have a small patch I'm testing out to deal with that.

ehuss added a commit to ehuss/rust that referenced this issue Aug 25, 2018
@ehuss
rustdoc: Fix gap on section anchor symbol when hovering.
1c888d5 
Fixes rust-lang#49485 for section headings.
@ehuss ehuss mentioned this issue Aug 25, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 26, 2018
@GuillaumeGomez
Rollup merge of rust-lang#53706 - ehuss:rustdoc-section-anchor, r=Gui…
f9eef71 
…llaumeGomez

rustdoc: Fix gap on section anchor symbol when hovering.

Fixes rust-lang#49485 for section headings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kzys @ehuss @pietroalbini @GuillaumeGomez @QuietMisdreavus