Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge E0539 and E0551? #51489

Closed
Havvy opened this issue Jun 11, 2018 · 0 comments · Fixed by #116413
Closed

Merge E0539 and E0551? #51489

Havvy opened this issue Jun 11, 2018 · 0 comments · Fixed by #116413
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Havvy
Copy link
Contributor

Havvy commented Jun 11, 2018

These errors both state "invalid meta item". E0539 triggers for the (compiler only) stability attributes when the meta items are not key=value e.g. #[stable(since)] triggers it. E0551 does the same, but for deprecation attributes. I propose merging the error numbers into E0551 since that one's currently emitted on stable.
@estebank estebank added the A-diagnostics Area: Messages for errors, warnings, and lints label Jan 8, 2019
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2019
@nnethercote nnethercote mentioned this issue Oct 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 4, 2023
@bors
Auto merge of rust-lang#116413 - nnethercote:rm-E0551, r=compiler-errors
f306362 
Remove E0551

Because it's the same as E0539.

Fixes rust-lang#51489.

r? `@Nilstrieb`
@bors bors closed this as completed in 0ece171 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove E0551 nnethercote/rust
3 participants
@Havvy @estebank @XAMPPRocky