Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various FFI run-pass tests probably should be using repr(C) as lint is instructing. #53858

Open
pnkfelix opened this issue Aug 31, 2018 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Aug 31, 2018

The following run-pass tests cause the improper_ctypes lint to fire. It would probably be fine (and trivial) to add #[repr(C)] to them.

pub struct TwoU16s {

pub struct TwoU32s {

pub struct TwoU64s {

pub struct TwoU8s {






pub struct KEYGEN {

struct TwoDoubles {

pub struct Foo {

(I'm just filing this ticket so I have something to point at from a PR for #53764.)

pnkfelix added a commit to pnkfelix/rust that referenced this issue Sep 3, 2018
pnkfelix added a commit to pnkfelix/rust that referenced this issue Sep 6, 2018
@memoryruins memoryruins added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 15, 2018
@asquared31415
Copy link
Contributor

@rustbot claim

@asquared31415
Copy link
Contributor

@rustbot release-assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

3 participants