Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#67133 #70055

Closed
rust-highfive opened this issue Mar 16, 2020 · 1 comment · Fixed by #70137
Closed

miri no longer builds after rust-lang/rust#67133 #70055

rust-highfive opened this issue Mar 16, 2020 · 1 comment · Fixed by #70137
Assignees
@eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #67133, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @oli-obk, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2020
@RalfJung RalfJung mentioned this issue Mar 16, 2020
Merged
bors added a commit to rust-lang/miri that referenced this issue Mar 16, 2020
@bors
Auto merge of #1233 - RalfJung:rustup, r=RalfJung
9082cc4 
rustup

Cc rust-lang/rust#70055
jonhoo added a commit to jonhoo/flurry that referenced this issue Mar 17, 2020
@jonhoo
Freeze miri as it's broken on nightly
bc64b38 
See rust-lang/rust#70055
@jonhoo jonhoo mentioned this issue Mar 17, 2020
Merged
jonhoo added a commit to jonhoo/flurry that referenced this issue Mar 17, 2020
@jonhoo
Freeze miri as it's broken on nightly
d05f6f2 
See rust-lang/rust#70055
@spastorino
Copy link
Member

Removing nomination, leaving this up to @RalfJung

@RalfJung RalfJung mentioned this issue Mar 19, 2020
Merged
@bors bors closed this as completed in 2602289 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update miri RalfJung/rust
5 participants
@spastorino @eddyb @RalfJung @oli-obk @rust-highfive