Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate const_field query #72264

Closed
oli-obk opened this issue May 16, 2020 · 2 comments · Fixed by #72538
Closed

Eliminate const_field query #72264

oli-obk opened this issue May 16, 2020 · 2 comments · Fixed by #72538
Assignees
@rustbot
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 16, 2020 •
edited by rustbot
Loading

Followup to #67901

I think we only have one use site of const_field left:

rust/src/librustc_codegen_ssa/mir/constant.rs

Line 69 in 7f65393

let field = bx.tcx().const_field(
and it iterates over all fields anyway. So we can call destructure_const instead and iterate over the resulting fields.

There should be no more results for searching const_field in the rust source after this, so some comments may need updating to mentioning destructure_const instead of const_field.

These mentoring instructions are a bit vague, I do realize that, so if you encounter any hickup of any magnitude, don't hesitate to write here or contact me via discord/zulip.

This issue has been assigned to @rakshith-ravi via this comment.
@oli-obk oli-obk added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-const-eval Area: Constant evaluation (MIR interpretation) labels May 16, 2020
@oli-obk oli-obk mentioned this issue May 16, 2020
Merged
@rakshith-ravi
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this May 16, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 16, 2020
@RalfJung
Copy link
Member

RalfJung commented May 21, 2020 •
edited
Loading

destructure_const

I don't think "destructure" is a word. The term I have seen for that (and the term that is commonly used for this operation in the theorem prover community) is "destruct".

EDIT: Okay, it is a word. Still, to me "destruct" sounds better. But maybe that's just because I am used to theorem provers?

@rakshith-ravi rakshith-ravi mentioned this issue May 24, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#72538 - rakshith-ravi:refactor/remove-const…
e6add8c 
…-query, r=oli-obk

Removed all instances of const_field.

Fixes rust-lang#72264

r? @oli-obk
@bors bors closed this as completed in b6a8915 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-const-eval Area: Constant evaluation (MIR interpretation) A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed all instances of const_field. rakshith-ravi/rust
5 participants
@RalfJung @oli-obk @jonas-schievink @rakshith-ravi @rustbot