Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.50] ./x.py install doc changed its default location #81967

Closed
cuviper opened this issue Feb 10, 2021 · 1 comment · Fixed by #81968
Closed

[1.50] ./x.py install doc changed its default location #81967

cuviper opened this issue Feb 10, 2021 · 1 comment · Fixed by #81968
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Feb 10, 2021

I tried this command:

DESTDIR=foo ./x.py install doc

I expected to see files installed to foo/usr/local/share/doc/rust/html

Instead, I see files installed to foo/usr/local/share/doc/html

This worked on Rust 1.49, and I noticed the change in testing the Rust 1.50 pre-release.

I'm going ahead to call this stable-to-stable since 1.50 is imminent.
@rustbot modify labels: +regression-from-stable-to-stable -regression-untriaged

The specific change appears to be commit 4050e27 from #81151, a backport of 2caf9bc from #80797, where the default install docdir changed from "share/doc/rust" to just "share/doc". cc @pietroalbini

Also note that config.toml still documents that the default is "share/doc/rust".
@rustbot rustbot added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Feb 10, 2021
This was referenced Feb 10, 2021
Merged
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Feb 11, 2021
@JohnTitor
Rollup merge of rust-lang#81968 - pietroalbini:fix-doc-install-path, …
551f510 
…r=Mark-Simulacrum

bootstrap: fix wrong docs installation path

This PR fixes rust-lang#81967, a regression introduced by rust-lang#80797. The commit has already been backported to stable 1.50.0.

r? `@Mark-Simulacrum`
JohnTitor added a commit to JohnTitor/rust that referenced this issue Feb 11, 2021
@JohnTitor
Rollup merge of rust-lang#81968 - pietroalbini:fix-doc-install-path, …
12be68c 
…r=Mark-Simulacrum

bootstrap: fix wrong docs installation path

This PR fixes rust-lang#81967, a regression introduced by rust-lang#80797. The commit has already been backported to stable 1.50.0.

r? ``@Mark-Simulacrum``
@apiraino
Copy link
Contributor

labeling to T-infra as per sibling PR #80797

@apiraino apiraino added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Feb 11, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 11, 2021
@Dylan-DPC
Rollup merge of rust-lang#81968 - pietroalbini:fix-doc-install-path, …
67cc5e4 
…r=Mark-Simulacrum

bootstrap: fix wrong docs installation path

This PR fixes rust-lang#81967, a regression introduced by rust-lang#80797. The commit has already been backported to stable 1.50.0.

r? ````@Mark-Simulacrum````
JohnTitor added a commit to JohnTitor/rust that referenced this issue Feb 12, 2021
@JohnTitor
Rollup merge of rust-lang#81968 - pietroalbini:fix-doc-install-path, …
77b038c 
…r=Mark-Simulacrum

bootstrap: fix wrong docs installation path

This PR fixes rust-lang#81967, a regression introduced by rust-lang#80797. The commit has already been backported to stable 1.50.0.

r? `````@Mark-Simulacrum`````
@bors bors closed this as completed in 459dda9 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bootstrap: fix wrong docs installation path pietroalbini/rust
3 participants
@cuviper @apiraino @rustbot