Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for #![feature(const_unsafecell_get_mut)] #88836

Closed
1 of 3 tasks
WaffleLapkin opened this issue Sep 10, 2021 · 8 comments · Fixed by #131177
Closed
1 of 3 tasks

Tracking Issue for #![feature(const_unsafecell_get_mut)] #88836

WaffleLapkin opened this issue Sep 10, 2021 · 8 comments · Fixed by #131177
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Comments

@WaffleLapkin
Copy link
Member

Feature gate: #![feature(const_unsafecell_get_mut)]

This is a tracking issue for UnsafeCell::get_mut as a const fn.

Public API

// core::cell

impl<T> UnsafeCell<T> {
    pub const fn get_mut(&mut self) -> &mut T;
}

Steps / History

Unresolved Questions

  • None yet.
@WaffleLapkin WaffleLapkin added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 10, 2021
@RalfJung
Copy link
Member

Cc @rust-lang/wg-const-eval

@tgross35
Copy link
Contributor

This is blocked on #57349, correct?

@RalfJung
Copy link
Member

Yeah, pretty much all the mutable reference/pointer stuff in const is blocked on that.

@workingjubilee workingjubilee added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 19, 2024
@workingjubilee
Copy link
Member

etc. etc. #57349 landed now let's see if we have consensus for stabilizing this?

@dtolnay
Copy link
Member

dtolnay commented Sep 19, 2024

@rfcbot fcp merge

const for https://doc.rust-lang.org/nightly/std/cell/struct.UnsafeCell.html#method.get_mut

@rfcbot
Copy link

rfcbot commented Sep 19, 2024 •
edited by Amanieu
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 19, 2024
@dtolnay dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 19, 2024
@workingjubilee workingjubilee mentioned this issue Sep 19, 2024
Closed
8 tasks
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 24, 2024
@rfcbot
Copy link

rfcbot commented Sep 24, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

This was referenced Sep 27, 2024
Open
Merged
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 4, 2024
@rfcbot
Copy link

rfcbot commented Oct 4, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this issue Oct 4, 2024
Open
3 tasks
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
@workingjubilee
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut…
cf2a713 
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
@workingjubilee
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut…
899543c 
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
@workingjubilee
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut…
882d660 
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 5, 2024
@rust-timer
Unrolled build for rust-lang#131177
78312b9 
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize 5 const_mut_refs-dependent API workingjubilee/rustc
6 participants
@RalfJung @dtolnay @tgross35 @rfcbot @WaffleLapkin @workingjubilee