Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The calling convention in rustboot needs adjustment #92

Closed
graydon opened this issue Jun 29, 2010 · 1 comment
Closed

The calling convention in rustboot needs adjustment #92

graydon opened this issue Jun 29, 2010 · 1 comment

Comments

@graydon
Copy link
Contributor

graydon commented Jun 29, 2010

The immediate problem is that 'extra args' (closure, object) come after the main args, and this makes it impossible to pass an interior-mode parametric-type argument. The workaround (terribly lame) is to only pass parametric args by alias or exterior.

Need to move extra-args to a (non-optional) leading argument position or take this opportunity to change the calling convention to use regs for the implicits (out, task, closure/obj). This is tempting. Fastcall is fast for a reason.

@froystig
Copy link
Contributor

Fixed in a sequence of commits ending in 25a38ee.

kazcw pushed a commit to kazcw/rust that referenced this issue Oct 23, 2018
This commit adds a new builder on CI for running tests in Intel's own emulator
and also adds an assertion that on this emulator no tests are skipped due to
missing CPU features by accident.

Closes rust-lang#92
eddyb pushed a commit to eddyb/rust that referenced this issue Jun 30, 2020
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Oct 26, 2020
ZuseZ4 referenced this issue in EnzymeAD/rust Mar 7, 2023
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants