Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker-plugin-lto.md: Correct the name of example c file #100072

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

oToToT
Copy link
Contributor

@oToToT oToToT commented Aug 2, 2022

The final output is linked with cmain.o, but we use main.o in the example.
This patch changes the name to cmain.c and cmain.o as the "C/C++ code as a dependency in Rust" section.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2022
@oToToT
Copy link
Contributor Author

oToToT commented Aug 6, 2022

Changing reviewer based on git blame.

r? @michaelwoerister

@michaelwoerister
Copy link
Member

Good catch! Thanks for the PR, @oToToT.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2022

📌 Commit e1eab53 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2022
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#98775 (rustdoc: improve scroll locking in the rustdoc mobile sidebars)
 - rust-lang#99479 (rustdoc-json: Remove doc FIXME for Import::id and explain)
 - rust-lang#100040 (Error on broken pipe but do not backtrace or ICE)
 - rust-lang#100072 (linker-plugin-lto.md: Correct the name of example c file)
 - rust-lang#100098 (Some "this expression has a field"-related fixes)
 - rust-lang#100226 (Do not manually craft a span pointing inside a multibyte character.)
 - rust-lang#100240 (Fail gracefully when const pattern is not structural match.)
 - rust-lang#100256 (Add some high-level docs to `FnCtxt` and `ItemCtxt`)
 - rust-lang#100261 (Set tainted errors bit before emitting coerce suggestions.)
 - rust-lang#100275 (also update anyhow in codegen_cranelift)
 - rust-lang#100281 (Remove more Clean trait implementations)
 - rust-lang#100314 (Mention `unit-test` in MIR opt test README)
 - rust-lang#100319 (Remove more Clean trait implementations)
 - rust-lang#100323 ([rustdoc] Don't render impl blocks with doc comment if they only contain private items by default)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2059391 into rust-lang:master Aug 10, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants