Allow more !Copy impls
#101875
Merged
Allow more !Copy impls
#101875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
rustbot
added
F-negative_impls
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
2 times, most recently
from
42a7499
to
7b2daf6
Compare
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
2 times, most recently
from
d1ccfd3
to
3d2e116
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
from
3d2e116
to
d0954bf
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
from
d0954bf
to
564de74
Compare
|
r? types (am sick right now, can't review much) |
lcnr
reviewed
Sep 23, 2022
lcnr
reviewed
Sep 23, 2022
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
from
564de74
to
3a0362f
Compare
lcnr
reviewed
Sep 23, 2022
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
from
3a0362f
to
d201498
Compare
|
Okay, now using
I don't think I can do |
|
@fmease: 🔑 Insufficient privileges: Not in reviewers |
fmease
force-pushed
the
allow-more-negative-copy-impls
branch
from
d201498
to
28e0c5a
Compare
|
ready |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Sep 26, 2022
…pls, r=lcnr Allow more `!Copy` impls You can already implement `!Copy` for a lot of types (with `#![feature(negative_impls)]`). However, before this PR you could not implement `!Copy` for ADTs whose fields don't implement `Copy` which didn't make any sense. Further, you couldn't implement `!Copy` for types impl'ing `Drop` (equally nonsensical). `@rustbot` label T-types F-negative_impls Fixes rust-lang#101836. r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2022
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#101875 (Allow more `!Copy` impls) - rust-lang#101996 (Don't duplicate region names for late-bound regions in print of Binder) - rust-lang#102181 (Add regression test) - rust-lang#102273 (Allow `~const` bounds on non-const functions) - rust-lang#102286 (Recover some items that expect braces and don't take semicolons) Failed merges: - rust-lang#102314 (Add a label to struct/enum/union ident name) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can already implement
!Copyfor a lot of types (with#![feature(negative_impls)]). However, before this PR you could not implement!Copyfor ADTs whose fields don't implementCopywhich didn't make any sense. Further, you couldn't implement!Copyfor types impl'ingDrop(equally nonsensical).@rustbot label T-types F-negative_impls
Fixes #101836.
r? types