Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #102948

Merged
merged 51 commits into from
Oct 12, 2022
Merged

Rollup of 8 pull requests #102948

merged 51 commits into from
Oct 12, 2022

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    72b3347 View commit details
    Browse the repository at this point in the history
  2. add test

    b-naber committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    29cc36f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Configuration menu
    Copy the full SHA
    39484ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a9e827 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    283c0e4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a72a66 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. always panic for invalid integer logarithm

    Lukas Markeffsky committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    69cafc0 View commit details
    Browse the repository at this point in the history
  2. add tests for panicking integer logarithms

    Lukas Markeffsky committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6acc29f View commit details
    Browse the repository at this point in the history
  3. remove unneeded attributes

    Lukas Markeffsky committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    b7dae8a View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Add lint for diagnostic migration

    rdvdev2 authored and CleanCut committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    bde80f7 View commit details
    Browse the repository at this point in the history
  2. Migrate weak_lang_items.rs

    rdvdev2 authored and CleanCut committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    2f74d1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17a4a68 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0315d7c View commit details
    Browse the repository at this point in the history
  5. Migrate InvalidAttrAtCrateLevel

    Co-authored-by: Nathan Stocks <cleancut@github.com>
    Co-authored-by: rdvdev2 <rdvdev2@gmail.com>
    rdvdev2 and CleanCut committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    2c3351c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c24a873 View commit details
    Browse the repository at this point in the history
  7. use consistent names

    CleanCut committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    b8e03cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1222541 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c103c30 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1e86226 View commit details
    Browse the repository at this point in the history
  11. errors: add emit_note/create_note

    Add `Noted` marker struct that implements `EmissionGuarantee` so that
    `emit_note` and `create_note` can be implemented for struct diagnostics.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco authored and CleanCut committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    f8ebc72 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3a74833 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0609c0f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    40d5f00 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c457abe View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    572f341 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    69766e4 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    96f92ea View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b17ec43 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f0afb88 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a7aa185 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    3fe8e00 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    be4059d View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    965dbf6 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    8e07a85 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    57eba4f View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    31c269a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Configuration menu
    Copy the full SHA
    b9e4a1c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. remove out-of-date fixme

    CleanCut committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    50e2795 View commit details
    Browse the repository at this point in the history
  2. make up your mind, rustfmt

    CleanCut committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5ef1c03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d933092 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. rustdoc: remove unused classes from sidebar

    Since 98f05a0 removed separate colors
    from the currently-selected item, there's no need to have item classes on
    sidebar links.
    notriddle committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b5963f0 View commit details
    Browse the repository at this point in the history
  2. rustdoc: remove unneeded .content selector from link colors

    Since 98f05a0 and
    b5963f0 removed color classes from sidebar
    items, there's no need for the selectors to be so specific any more.
    
    This commit does have to change `h1.fqn a` to just be `h1 a`, so that the
    header link color selector is less specific than the typed link at the end.
    Since rust-lang#89506 made docblocks start at `h2`, the main page link header should
    be the only h1 in the page now.
    notriddle committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    062284a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    a7f58af View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#102110 - CleanCut:migrate_rustc_passes_diag…

    …nostics, r=davidtwco
    
    Migrate rustc_passes diagnostics
    
    Picks up abandoned work from rust-lang#100870
    
    I would like to do this collaboratively, as there is a lot of work! Here's the process:
    
    - Comment below that you are willing to help and I will add you as a collaborator to my `rust` fork (that gives you write access)
    - Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
    - Do the work, push up a commit, comment that you're done with that file/task
    - Repeat until done 😄
    
    ### Files to Migrate (in `compiler/rustc_passes/src/`)
    
    - [x] check_attr.rs ``@CleanCut``
    - [x] check_const.rs ``@CleanCut``
    - [x] dead.rs ``@CleanCut``
    - [x] debugger_visualizer.rs ``@CleanCut``
    - [x] diagnostic_items.rs ``@CleanCut``
    - [x] entry.rs ``@CleanCut``
    - [x] lang_items.rs ``@CleanCut``
    - [x] layout_test.rs ``@CleanCut``
    - [x] lib_features.rs ``@CleanCut``
    - [x] ~liveness.rs~ ``@CleanCut`` Nothing to do
    - [x] loops.rs ``@CleanCut``
    - [x] naked_functions.rs ``@CleanCut``
    - [x] stability.rs ``@CleanCut``
    - [x] weak_lang_items.rs ``@CleanCut``
    
    ### Tasks
    
    - [x] Rebase on current `master` ``@CleanCut``
    - [x] Review work from [the earlier PR](rust-lang#100870) and make sure it all looks good
      - [x] compiler/rustc_error_messages/locales/en-US/passes.ftl ``@CleanCut``
      - [x] compiler/rustc_passes/src/check_attr.rs ``@CleanCut``
      - [x] compiler/rustc_passes/src/errors.rs ``@CleanCut``
      - [x] compiler/rustc_passes/src/lang_items.rs ``@CleanCut``
      - [x] compiler/rustc_passes/src/lib.rs ``@CleanCut``
      - [x] compiler/rustc_passes/src/weak_lang_items.rs ``@CleanCut``
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    32471a7 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#102187 - b-naber:inline-const-source-info, …

    …r=eholk
    
    Use correct location for type tests in promoted constants
    
    Previously we forgot to remap the location in a type test collected when visiting the body of a promoted constant back to the usage location, causing an ICE when trying to get span information for that type test.
    
    Fixes rust-lang#102117
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5e04567 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#102239 - joshtriplett:style-guide, r=calebc…

    …artwright
    
    Move style guide to rust-lang/rust
    
    Per [RFC 3309](https://rust-lang.github.io/rfcs/3309-style-team.html).
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f8723f9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#102578 - lukas-code:ilog-panic, r=m-ou-se

    Panic for invalid arguments of `{integer primitive}::ilog{,2,10}` in all modes
    
    Decision made in rust-lang#100422 (comment)
    
    resolves rust-lang#100422
    
    tracking issue: rust-lang#70887
    
    r? `@m-ou-se`
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d8091f8 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#102811 - the8472:bufread-memset, r=m-ou-se

    Use memset to initialize readbuf
    
    The write loop was found to be slow in rust-lang#102727
    
    The proper fix is in rust-lang#102760 but this might still help debug builds and code running under miri by using the write_bytes intrinsic instead of writing one byte at a time.
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    658169b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#102890 - camsteffen:adt-sized-representabil…

    …ity, r=cjgillot
    
    Check representability in adt_sized_constraint
    
    Now that representability is a query, we can use it to preemptively avoid a cycle in `adt_sized_constraint`.
    
    I moved the representability check into `check_mod_type_wf` to avoid a scenario where rustc quits before checking all the types for representability. This also removes the check from rustdoc, which is alright AFAIK.
    
    r? ``@cjgillot``
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c8a8e7d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#102913 - SparrowLii:import-candidate, r=com…

    …piler-errors
    
    unify `IsPattern` and `IsImport` enum in `show_candidates`
    
    Follow-up of rust-lang#102876
    A binding cannot appear in both pattern and import at the same time, so it makes sense to unify them
    r? `@compiler-errors`
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    252ce10 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#102924 - notriddle:notriddle/sidebar-link-c…

    …lass, r=GuillaumeGomez
    
    rustdoc: remove unused classes from sidebar links
    
    Since rust-lang@98f05a0 removed separate colors from the currently-selected item, there's no need to have item classes on sidebar links.
    
    Preview: https://notriddle.com/notriddle-rustdoc-demos/sidebar-link-class/std/vec/struct.Vec.html
    
    While cleaning up the CSS to remove unneeded `.content` selectors, this PR changes the `h1.fqn a` CSS selector to just be `h1 a`, so that the header link color selector is less specific than the typed link at the end. Since rust-lang#89506 made docblocks start at `h2`, the main page link header should be the only h1 in the page now.
    Dylan-DPC authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    96bcced View commit details
    Browse the repository at this point in the history