Add missing checks for doc(cfg_hide(...))
#102954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rustbot
added
the
A-translation
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #102948) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
cfg-hide-attr-checks
branch
from
f855c7d
to
656dadf
Compare
|
Fixed the conflict. |
Manishearth
requested changes
Oct 13, 2022
| @@ -934,6 +934,22 @@ impl CheckAttrVisitor<'_> { | |||
| is_valid | |||
| } | |||
|
|
|||
| /// Check that the `#![doc(cfg_hide(...))]` attribute is well formatted. Returns `true` if | |||
There was a problem hiding this comment.
issue: please document what the rules for it being well formatted are
GuillaumeGomez
force-pushed
the
cfg-hide-attr-checks
branch
from
656dadf
to
6f0c247
Compare
|
I updated the docs. Allowing it on items sounds like a good idea even though I'm not completely sure why you would want to hide a |
Manishearth
approved these changes
Oct 14, 2022
|
@bors r+ @GuillaumeGomez because you're using internal cfgs or something weird for your module. This is quite common. |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 15, 2022
…s, r=Manishearth Add missing checks for `doc(cfg_hide(...))` Part of rust-lang#43781. The `doc(cfg_hide(...))` attribute can only be used at the crate level and takes a list of attributes as argument. r? `@Manishearth`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 15, 2022
…s, r=Manishearth Add missing checks for `doc(cfg_hide(...))` Part of rust-lang#43781. The `doc(cfg_hide(...))` attribute can only be used at the crate level and takes a list of attributes as argument. r? ``@Manishearth``
This was referenced Oct 15, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102773 (Use semaphores for thread parking on Apple platforms) - rust-lang#102884 (resolve: Some cleanup, asserts and tests for lifetime ribs) - rust-lang#102954 (Add missing checks for `doc(cfg_hide(...))`) - rust-lang#102998 (Drop temporaries created in a condition, even if it's a let chain) - rust-lang#103003 (Fix `suggest_floating_point_literal` ICE) - rust-lang#103041 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43781.
The
doc(cfg_hide(...))attribute can only be used at the crate level and takes a list of attributes as argument.r? @Manishearth