-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #103099
Rollup of 6 pull requests #103099
Commits on Sep 28, 2022
-
Fix missing explanation of where borrowed reference is used when the …
…borrow occurs in loop iteration
Yan Chen committedSep 28, 2022 Configuration menu - View commit details
-
Copy full SHA for b3bf931 - Browse repository at this point
Copy the full SHA b3bf931View commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b3b6fbc - Browse repository at this point
Copy the full SHA b3b6fbcView commit details
Commits on Oct 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 49f34bd - Browse repository at this point
Copy the full SHA 49f34bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e14d2ef - Browse repository at this point
Copy the full SHA e14d2efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11a40ec - Browse repository at this point
Copy the full SHA 11a40ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7334526 - Browse repository at this point
Copy the full SHA 7334526View commit details -
rustdoc: make the help button a link to a page
This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page.
Configuration menu - View commit details
-
Copy full SHA for ae4ad9a - Browse repository at this point
Copy the full SHA ae4ad9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f59981 - Browse repository at this point
Copy the full SHA 6f59981View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f501e - Browse repository at this point
Copy the full SHA 65f501eView commit details -
Rollup merge of rust-lang#102080 - yanchen4791:issue-99824-fix, r=cjg…
…illot Fix missing explanation of where the borrowed reference is used when the same borrow occurs multiple times due to loop iterations Fix rust-lang#99824. Problem of the issue: If a borrow occurs in a loop, the borrowed reference could be invalidated at the same place at next iteration of the loop. When this happens, the point where the borrow occurs is the same as the intervening point that might invalidate the reference in the loop. This causes a problem for the current code finding the point where the resulting reference is used, so that the explanation of the cause will be missing. As the second point of "explain all errors in terms of three points" (see [leveraging intuition framing errors in terms of points"](https://rust-lang.github.io/rfcs/2094-nll.html#leveraging-intuition-framing-errors-in-terms-of-points), this explanation is very helpful for user to understand the error. In the current implementation, the searching region for finding the location where the borrowed reference is used is limited to between the place where the borrow occurs and the place where the reference is invalidated. If those two places happen to be the same, which indicates that the borrow and invalidation occur at the same place in a loop, the search will fail. One solution to the problem is when these two places are the same, find the terminator of the loop, and then use the location of the loop terminator instead of the location of the borrow for the region to find the place where the borrowed reference is used.
Configuration menu - View commit details
-
Copy full SHA for 9e3000a - Browse repository at this point
Copy the full SHA 9e3000aView commit details -
Rollup merge of rust-lang#103033 - alyssais:pkg-config, r=joshtriplett
Update pkg-config I'd like to be able to cross-compile rustc in a scenario where it'd be really helpful to have rust-lang/pkg-config-rs@cd3ccca. I've done some test builds of the compiler on x86_64 linux, targeting x86_64 linux and aarch64 linux.
Configuration menu - View commit details
-
Copy full SHA for 5ecb735 - Browse repository at this point
Copy the full SHA 5ecb735View commit details -
Rollup merge of rust-lang#103060 - notriddle:notridddle/help-page, r=…
…GuillaumeGomez rustdoc: make the help button a link to a page This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page. Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html
Configuration menu - View commit details
-
Copy full SHA for ac26c0e - Browse repository at this point
Copy the full SHA ac26c0eView commit details -
Rollup merge of rust-lang#103080 - ohno418:fix-hir-pretty-print-lifet…
…imes, r=cjgillot pretty: fix to print some lifetimes on HIR pretty-print HIR pretty-printer doesn't seem to print some lifetimes in types. This PR fixes that. Closes rust-lang#85089
Configuration menu - View commit details
-
Copy full SHA for 0aaf7b2 - Browse repository at this point
Copy the full SHA 0aaf7b2View commit details -
Rollup merge of rust-lang#103082 - gimbles:patch-1, r=cjgillo
Surround type with backticks Very smol PR. :)
Configuration menu - View commit details
-
Copy full SHA for 8d21784 - Browse repository at this point
Copy the full SHA 8d21784View commit details -
Rollup merge of rust-lang#103088 - GuillaumeGomez:fix-settings-page, …
…r=notriddle Fix settings page Thanks to rust-lang#103060, I discovered that the settings page was badly rendered. This PR fixes it. Before: ![Screenshot from 2022-10-15 16-02-41](https://user-images.githubusercontent.com/3050060/195990668-42e0b16b-3146-4864-b822-6f6a80fb77a5.png) After: ![Screenshot from 2022-10-15 16-02-31](https://user-images.githubusercontent.com/3050060/195990664-20f967df-8989-4336-bca9-be52baab8e81.png) r? ``@notriddle``
Configuration menu - View commit details
-
Copy full SHA for 0d01e40 - Browse repository at this point
Copy the full SHA 0d01e40View commit details