Fix SelfVisitor::is_self_ty ICE
#103221
Merged
Fix SelfVisitor::is_self_ty ICE
#103221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Oct 19, 2022
| struct S {} | ||
|
|
||
| impl S { | ||
| fn f(self: &S::x) {} //~ ERROR ambiguous associated type |
There was a problem hiding this comment.
Hmm.. that error seems incorrect. Maybe we should bubble out a new ResolutionError variant from find_lifetime_for_self by changing the lifetime field of the visitor to a Result that, once set to Err simply doesn't do anything else anymore.
There was a problem hiding this comment.
The error does not come from find_lifetime_forself, it looks like the regular error because S` is known to be a type and we expect a type.
There was a problem hiding this comment.
Before this regression, rustc caused the following error:
error[E0223]: ambiguous associated type
--> src/main.rs:4:17
|
4 | fn f(self: &S::x) {} //~ ERROR ambiguous associated type
| ^^^^ help: use fully-qualified syntax: `<S as Trait>::x`
cjgillot
reviewed
Oct 19, 2022
| struct S {} | ||
|
|
||
| impl S { | ||
| fn f(self: &S::x) {} //~ ERROR ambiguous associated type |
There was a problem hiding this comment.
The error does not come from find_lifetime_forself, it looks like the regular error because S` is known to be a type and we expect a type.
rustbot
added
the
A-testsuite
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 20, 2022
Fix `SelfVisitor::is_self_ty` ICE Fixes rust-lang#103202
This was referenced Oct 20, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 20, 2022
Fix `SelfVisitor::is_self_ty` ICE Fixes rust-lang#103202
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103221 (Fix `SelfVisitor::is_self_ty` ICE) - rust-lang#103230 (Clarify startup) - rust-lang#103281 (Adjust `transmute{,_copy}` to be clearer about which of `T` and `U` is input vs output) - rust-lang#103288 (Fixed docs typo in `library/std/src/time.rs`) - rust-lang#103296 (+/- shortcut now only expand/collapse, not both) - rust-lang#103297 (fix typo) - rust-lang#103313 (Don't label `src/test` tests as `A-testsuite`) - rust-lang#103315 (interpret: remove an incorrect assertion) - rust-lang#103319 (Improve "`~const` is not allowed here" message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103202