Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark std::os::wasi::io::AsFd etc. as stable. #103308

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Mark std::os::wasi::io::AsFd etc. as stable. #103308

merged 2 commits into from
Oct 21, 2022

Conversation

sunfishcode
Copy link
Member

io_safety was stabilized in Rust 1.63, so mark the io_safety exports in std::os::wasi::io as stable.

Fixes #103306.

@sunfishcode
Mark std::os::wasi::io::AsFd etc. as stable.
e56b84e 
io_safety was stabilized in Rust 1.63, so mark the io_safety exports in
`std::os::wasi::io` as stable.

Fixes rust-lang#103306.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 20, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022
@compiler-errors
Copy link
Member

This probably should also be beta (and stable?) nominated, so doing that now.

@compiler-errors compiler-errors added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Oct 20, 2022
@joshtriplett
Copy link
Member

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit e56b84e has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
joshtriplett
joshtriplett reviewed Oct 20, 2022
View reviewed changes
library/std/src/os/wasi/io/mod.rs Outdated
@@ -2,5 +2,5 @@

#![unstable(feature = "wasi_ext", issue = "71213")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you also need the module itself to be stable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. Fixed now.

@joshtriplett
Copy link
Member

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit 7ac645a has been approved by joshtriplett

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 21, 2022

⌛ Testing commit 7ac645a with merge b1ab3b7...

@bors
Copy link
Contributor

bors commented Oct 21, 2022

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing b1ab3b7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2022
@bors bors merged commit b1ab3b7 into rust-lang:master Oct 21, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b1ab3b7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@m-ou-se
Copy link
Member

m-ou-se commented Oct 26, 2022

This briefly came up in the libs meeting today: https://rust-lang.zulipchat.com/#narrow/stream/259402-t-libs.2Fmeetings/topic/Meeting.202022-10-26/near/306260701

We're fine with backporting it to 1.65.0 (which is released in eight days from now), but it'd be good if this says version = "1.65.0" instead of version = "1.63.0" to avoid confusion for users on 1.64.0.

@Mark-Simulacrum Mark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 29, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.66.0, 1.65.0 Oct 29, 2022
@Mark-Simulacrum Mark-Simulacrum removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Oct 29, 2022
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 29, 2022
@Mark-Simulacrum
Adjust stabilization version to 1.65.0 for wasi fds
5410ac1 
See rust-lang#103308 (comment)
for this ask.
This was referenced Oct 29, 2022
Merged
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2022
@bors
Auto merge of rust-lang#103739 - Mark-Simulacrum:beta-next, r=Mark-Si…
90b3882 
…mulacrum

[beta] backport rollup

* poll_fn and Unpin: fix pinning rust-lang#102737
* Support raw-dylib functions being used inside inlined functions rust-lang#102988
* Fix line numbers for MIR inlined code rust-lang#103071
* Add architectures to fn create_object_file rust-lang#103240
* Add eval hack in super_relate_consts back rust-lang#103279
* Mark std::os::wasi::io::AsFd etc. as stable. rust-lang#103308
* Truncate thread names on Linux and Apple targets rust-lang#103379
* Do not consider repeated lifetime params for elision. rust-lang#103450
* rustdoc: add missing URL redirect rust-lang#103588
* Remove commit_if_ok probe from NLL type relation rust-lang#103601

Also includes a copy of the release notes.

r? `@ghost`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 15, 2022
@matthiaskrgr
Rollup merge of rust-lang#103734 - Mark-Simulacrum:fix-version-stabil…
e309b79 
…ized, r=JohnTitor

Adjust stabilization version to 1.65.0 for wasi fds

See rust-lang#103308 (comment) for this ask.

Backport of that PR to beta (1.65.0) will include a similar patch.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@Mark-Simulacrum
Adjust stabilization version to 1.65.0 for wasi fds
e3a8fcb 
See rust-lang/rust#103308 (comment)
for this ask.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@matthiaskrgr
Rollup merge of #103734 - Mark-Simulacrum:fix-version-stabilized, r=J…
18dee49 
…ohnTitor

Adjust stabilization version to 1.65.0 for wasi fds

See rust-lang/rust#103308 (comment) for this ask.

Backport of that PR to beta (1.65.0) will include a similar patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

std::os::wasi::io::AsFd regression on Rust 1.64
9 participants
@sunfishcode @rust-highfive @rustbot @compiler-errors @joshtriplett @bors @rust-timer @m-ou-se @Mark-Simulacrum