Convert predicates into Predicate in the Obligation constructor #104483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its name is now not accurate anymore, but we'll adjust that later
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
r? @compiler-errors maybe? |
|
Nothing wrong with this PR, but I do think it's a bit weird for |
|
@bors r+ |
|
🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Challenge accepted |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…r=compiler-errors Convert predicates into Predicate in the Obligation constructor instead of having almost all callers do that. This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…r=compiler-errors Convert predicates into Predicate in the Obligation constructor instead of having almost all callers do that. This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…r=compiler-errors Convert predicates into Predicate in the Obligation constructor instead of having almost all callers do that. This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#103852 (Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl`) - rust-lang#104366 (Simplify settings theme choice) - rust-lang#104433 (Fix `emit_unused_delims_expr` ICE) - rust-lang#104444 (Fix ICE in in_operand for ty error) - rust-lang#104483 (Convert predicates into Predicate in the Obligation constructor) - rust-lang#104496 (Don't attempt to normalize compiler backtraces) - rust-lang#104503 (rustdoc: remove redundant font-color CSS on `.where`) - rust-lang#104508 (Check `dyn*` return type correctly) - rust-lang#104515 (ICE fixing, remove is_tainted_by_errors since we have ty_error for delay bug) - rust-lang#104532 (Migrate tooltip style to CSS variables) - rust-lang#104545 (Readd the matches_macro diag item) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
…r=compiler-errors Convert predicates into Predicate in the Obligation constructor instead of having almost all callers do that. This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 23, 2022
…r=jackh726 get rid of to_poly_trait_predicate and many `without_const` calls continuation of rust-lang#104483 r? `@compiler-errors`
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 23, 2022
…r=jackh726 get rid of to_poly_trait_predicate and many `without_const` calls continuation of rust-lang#104483 r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having almost all callers do that.
This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).