Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup macro-expanded code in rustc_type_ir #105362

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

WaffleLapkin
Copy link
Member

We could of course just leave this as-is, but every time I go-to-def to this file it's painful to see all this (&A(ref __self_1_0),) stuff.

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 6, 2022

@bors delegate+

r=me with some debug asserts added (they'll save ppl some pain when they add new TyKind variants)

@bors
Copy link
Contributor

bors commented Dec 6, 2022

✌️ @WaffleLapkin can now approve this pull request

@WaffleLapkin
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit c76c5d87696d78c1329ab98fa3766c844e0dfb74 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@WaffleLapkin
Copy link
Member Author

WaffleLapkin commented Dec 6, 2022

oops

@WaffleLapkin
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit e12d222 has been approved by oli-obk

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104898 (Put all cached values into a central struct instead of just the stable hash)
 - rust-lang#105004 (Fix `emit_unused_delims_expr` ICE)
 - rust-lang#105174 (Suggest removing struct field from destructive binding only in shorthand scenario)
 - rust-lang#105250 (Replace usage of `ResumeTy` in async lowering with `Context`)
 - rust-lang#105286 (Add -Z maximal-hir-to-mir-coverage flag)
 - rust-lang#105320 (rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles)
 - rust-lang#105349 (Point at args in associated const fn pointers)
 - rust-lang#105362 (Cleanup macro-expanded code in `rustc_type_ir`)
 - rust-lang#105370 (Remove outdated syntax from trait alias pretty printing)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4f527a5 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
@WaffleLapkin WaffleLapkin deleted the 🙅 branch December 16, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants