Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest remove last method call when type coerce with expected type #105872

Merged
merged 2 commits into from
Dec 24, 2022
Merged

Suggest remove last method call when type coerce with expected type #105872

merged 2 commits into from
Dec 24, 2022

Conversation

chenyukang
Copy link
Member

Fixes #105494

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2022
@bors
Copy link
Contributor

bors commented Dec 22, 2022

☔ The latest upstream changes (presumably #106034) made this pull request unmergeable. Please resolve the merge conflicts.

@eholk
Copy link
Contributor

eholk commented Dec 22, 2022

r=me after resolving the conflicts.

@chenyukang chenyukang force-pushed the yukang/fix-105494-remove-method-call branch from 8d3ab51 to 3b38adf Compare December 23, 2022 03:58
@compiler-errors
Copy link
Member

@bors r=eholk

@bors
Copy link
Contributor

bors commented Dec 23, 2022

📌 Commit 3b38adf has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2022
@bors
Auto merge of rust-lang#106111 - matthiaskrgr:rollup-nnpoe5h, r=matth…
8766bbd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105465 (Improve top-level docs)
 - rust-lang#105872 (Suggest remove last method call when type coerce with expected  type)
 - rust-lang#106032 (std: only use LFS function on glibc)
 - rust-lang#106078 (Provide more context on FileCheck failures)
 - rust-lang#106100 (Codegen test for derived `<` on trivial newtype [TEST ONLY])
 - rust-lang#106109 (rustdoc: make line number CSS for doc comment and scraped the same)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a952b61 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@3tilley 3tilley mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@eholk eholk eholk approved these changes

Assignees

@eholk eholk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Compiler suggestion "try using a conversion method: .to_string"
5 participants
@chenyukang @rustbot @bors @eholk @compiler-errors