Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] separate impls for refs to simplifiable types #106155

Closed
wants to merge 3 commits into from
Closed

[perf] separate impls for refs to simplifiable types #106155

wants to merge 3 commits into from

Commits on May 31, 2023

  1. separate impls for refs to simplifiable types 

    Separate impls for references to simplifiable types to allow for faster lookups: the
set of possibly matching impls is smaller than if we stored them all as
`SimplifiedType::RefSimplifiedType`.
    @lqd
    lqd committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a9d7810 View commit details
    Browse the repository at this point in the history

  2. clean-up for_each_impl to use all_impls 

    handle `impls_for_ref_x` and reduce duplication when iterating over all impls.

also: use it in `for_each_relevant_impl_treating_projections`
    @lqd
    lqd committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f2b58f3 View commit details
    Browse the repository at this point in the history

  3. return refs to simplifiable types in non_blanket_impls_for_ty 

    for users of the API, we return impls from `non_blanket_impls` and `impls_for_ref_x` as if they
weren't separated.
    @lqd
    lqd committed May 31, 2023
    Configuration menu
    Copy the full SHA
    030f9bb View commit details
    Browse the repository at this point in the history