Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core::any docs #106184

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Fix core::any docs #106184

merged 1 commit into from
Dec 28, 2022

Conversation

albertlarsan68
Copy link
Member

@albertlarsan68 albertlarsan68 commented Dec 27, 2022 •
edited
Loading

Thanks to @pbevin in #106154

Closes #106154

@rustbot labels +A-docs

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Dec 27, 2022
@Noratrieb
Copy link
Member

Thanks, but you mean core::any, not core::pin, right?
r? Nilstrieb
r=me with the commit message and PR title adjusted (also, small tip for the future: you should avoid mentioning issues or people in commit messages, as it can cause a lot of backreferences on the issue when you repeatedly force push a new commit)

@rustbot rustbot assigned Noratrieb and unassigned scottmcm Dec 27, 2022
@albertlarsan68 albertlarsan68 changed the title Fix core::pin docs Fix core::any docs Dec 27, 2022
@albertlarsan68
Copy link
Member Author

albertlarsan68 commented Dec 27, 2022 •
edited
Loading

@bors r=Nilstrieb rollup
@rustbot ready
@Nilstrieb Done !

@bors
Copy link
Contributor

bors commented Dec 27, 2022

@albertlarsan68: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Dec 27, 2022

@albertlarsan68: 🔑 Insufficient privileges: not in try users

@scottmcm
Copy link
Member

@bors r=Nilstrieb rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit 6d332c4 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 28, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#106184 - albertlarsan68:docs-106154, r=Nils…
e28916b 
…trieb

Fix `core::any` docs

Thanks to `@pbevin` in rust-lang#106154

Closes rust-lang#106154

`@rustbot` labels +A-docs
@fee1-dead fee1-dead mentioned this pull request Dec 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2022
@bors
Auto merge of rust-lang#106209 - fee1-dead-contrib:rollup-47ysdcu, r=…
6a20f7d 
…fee1-dead

Rollup of 9 pull requests

Successful merges:

 - rust-lang#94145 (Test leaking of BinaryHeap Drain iterators)
 - rust-lang#103945 (Remove `iter::Empty` hack)
 - rust-lang#104024 (Fix `unused_must_use` warning for `Box::from_raw`)
 - rust-lang#104708 (Fix backoff doc to match implementation)
 - rust-lang#105347 (Account for `match` expr in single line)
 - rust-lang#105484 (Implement allow-by-default `multiple_supertrait_upcastable` lint)
 - rust-lang#106184 (Fix `core::any` docs)
 - rust-lang#106201 (Emit fewer errors on invalid `#[repr(transparent)]` on `enum`)
 - rust-lang#106205 (Remove some totally duplicated files in `rustc_infer`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 45d6f02 into rust-lang:master Dec 28, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 28, 2022
@albertlarsan68 albertlarsan68 deleted the docs-106154 branch December 28, 2022 13:08
@dtolnay dtolnay mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Update get_context_ref -> get_context_by_ref in core::any
5 participants
@albertlarsan68 @rustbot @Noratrieb @bors @scottmcm