Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check -Z query-dep-graph is enabled if -Z dump-dep-graph (#106736) #106912

Merged
merged 1 commit into from
Jan 16, 2023
Merged

check -Z query-dep-graph is enabled if -Z dump-dep-graph (#106736) #106912

merged 1 commit into from
Jan 16, 2023

Conversation

gftea
Copy link
Contributor

@gftea gftea commented Jan 15, 2023 •
edited
Loading

PR to solve #106736, r? @cjgillot

@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2023
@rustbot rustbot assigned cjgillot and unassigned Noratrieb Jan 15, 2023
@cjgillot
Copy link
Contributor

Could you add a test that this message appears?

@Noratrieb
Copy link
Member

The test looks good. As a final step, could you squash the commits? If you need help doing that, feel free to ask.

@gftea
Copy link
Contributor Author

gftea commented Jan 16, 2023

The test looks good. As a final step, could you squash the commits? If you need help doing that, feel free to ask.

Done, please check @Nilstrieb

@Noratrieb
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 16, 2023

📌 Commit 2c5583e has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2023
@bors
Auto merge of rust-lang#106945 - matthiaskrgr:rollup-c5or8z3, r=matth…
4781233 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#105954 (Update instrument-coverage.md)
 - rust-lang#106835 (new trait solver: rebase impl substs for gats correctly)
 - rust-lang#106912 (check -Z query-dep-graph is enabled if -Z dump-dep-graph (rust-lang#106736))
 - rust-lang#106940 (Improve a TAIT error and add an error code plus documentation)
 - rust-lang#106942 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37378ee into rust-lang:master Jan 16, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gftea @rustbot @cjgillot @Noratrieb @bors