Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tests back into rustc source tarball #107239

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 23, 2023

They were missing after recent move from src/test to tests.

cc @albertlarsan68

Fixes #107081

They were missing after recent move from src/test to tests.
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 23, 2023
@compiler-errors
Copy link
Member

Edited to reflect that this fixes #107081

@albertlarsan68 albertlarsan68 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jan 24, 2023
@albertlarsan68
Copy link
Member

LGTM, but I don't have time for a full review.

@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jan 24, 2023
@Mark-Simulacrum
Copy link
Member

Accepting beta-backport as well, we need this for 1.68 tarballs and I'd rather avoid reverting the test move (it'll make backports more annoying).

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 24, 2023

📌 Commit 7f5ce94 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 25, 2023
Bring tests back into rustc source tarball

They were missing after recent move from src/test to tests.

cc `@albertlarsan68`

Fixes rust-lang#107081
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 25, 2023
Bring tests back into rustc source tarball

They were missing after recent move from src/test to tests.

cc ``@albertlarsan68``

Fixes rust-lang#107081
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#105345 (Add hint for missing lifetime bound on trait object when type alias is used)
 - rust-lang#106897 (Tweak E0597)
 - rust-lang#106944 (Suggest using a lock for `*Cell: Sync` bounds)
 - rust-lang#107239 (Bring tests back into rustc source tarball)
 - rust-lang#107244 (rustdoc: rearrange HTML in primitive reference links)
 - rust-lang#107255 (add test where we ignore hr implied bounds)
 - rust-lang#107256 (Delete `SimplifyArmIdentity` and `SimplifyBranchSame` mir opts)
 - rust-lang#107266 (rustdoc: prohibit scroll bar on source viewer in Safari)
 - rust-lang#107282 (erica solver: implement builtin `Pointee` trait impl candidates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7baa9f into rust-lang:master Jan 26, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 26, 2023
@tmiasko tmiasko deleted the tests branch January 26, 2023 09:15
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 14, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.69.0, 1.68.0 Feb 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2023
…mulacrum

[beta] backport

*  Do not eagerly recover for bad impl Trait types in macros rust-lang#107813
*  Fix infinite loop in rustdoc get_all_import_attributes function rust-lang#107357
*  Bring tests back into rustc source tarball rust-lang#107239

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly source tarballs don't have tests/ directory
6 participants