Implement unsizing in the new trait solver #107245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Jan 24, 2023
lcnr
reviewed
Jan 25, 2023
compiler-errors
force-pushed
the
new-solver-unsizing
branch
from
c9b9708
to
302a445
Compare
|
Waiting on #107146 to land. |
|
☔ The latest upstream changes (presumably #103902) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
new-solver-unsizing
branch
from
302a445
to
071fa04
Compare
|
☔ The latest upstream changes (presumably #107309) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
new-solver-unsizing
branch
from
071fa04
to
e444b18
Compare
compiler-errors
force-pushed
the
new-solver-unsizing
branch
from
e444b18
to
9902ea5
Compare
|
@bors r=lcnr rollup (only affects new solver) |
|
📌 Commit 9902ea5dd8e115d56df4ed5b0e923a9c52caa165 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
compiler-errors
force-pushed
the
new-solver-unsizing
branch
from
9902ea5
to
f7fc0b7
Compare
|
@bors r=lcnr |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#107245 (Implement unsizing in the new trait solver) - rust-lang#107445 (Remove `GenFuture` from core) - rust-lang#107473 (Update books) - rust-lang#107476 (rustdoc: remove unnecessary wrapper `div.item-decl` from HTML) - rust-lang#107477 (Migrate last part of CSS themes to CSS variables) - rust-lang#107479 (Use `ObligationCtxt::new_in_snapshot` in `satisfied_from_param_env`) - rust-lang#107482 (rustdoc: remove meta keywords from HTML) - rust-lang#107494 (fix link in std::path::Path::display()) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes hello world compile! Ignore the first commit, that's just #107146 which is waiting on merge.
I'll leave some comments inline about design choices that might be debatable.
r? @lcnr (until we have a new trait solver reviewer group...)